[SecurityBundle] Fix switch_user provider configuration handling #34759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case? Maybe update |
fancyweb
force-pushed
the
security-bundle-switch-user-fix
branch
from
7353c64
to
417169b
Compare
|
Done. |
chalasr
approved these changes
Dec 2, 2019
darielopper
approved these changes
Dec 2, 2019
|
Good catch, thanks @fancyweb. |
chalasr
pushed a commit
that referenced
this pull request
Dec 3, 2019
…ndling (fancyweb)
This PR was merged into the 4.4 branch.
Discussion
----------
[SecurityBundle] Fix switch_user provider configuration handling
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
The default provider here can be null if there are multiple configured providers configured + the firewall doesn't define its provider at the root level + it is anonymous, ie:
```yaml
providers:
my_provider:
# ...
monitor_provider:
# ...
firewalls:
main:
switch_user:
provider: my_provider
anonymous: true
# ...
```
Commits
-------
417169b [SecurityBundle] Fix switch_user provider configuration handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default provider here can be null if there are multiple configured providers configured + the firewall doesn't define its provider at the root level + it is anonymous, ie: