[FrameworkBundle][SodiumVault] Create secrets directory only when it is used #34820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
fwb-lazy-dir-creation-sodium-vault
branch
from
dc94381
to
4858dac
Compare
fancyweb
force-pushed
the
fwb-lazy-dir-creation-sodium-vault
branch
from
4858dac
to
c861570
Compare
nicolas-grekas
approved these changes
Dec 4, 2019
fabpot
approved these changes
Dec 5, 2019
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Dec 5, 2019
…ly when it is used (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][SodiumVault] Create secrets directory only when it is used | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - FWB `secrets` is enabled by default. After upgrading an app to 4.4, a directory is created (and checked on every request) even if I don't use this feature. Can't we just disable it by default btw? Commits ------- c861570 [FrameworkBundle][SodiumVault] Create secrets directory only when needed
|
Thank you, symfony recipe should also be updated: https://github.com/symfony/recipes/tree/master/symfony/framework-bundle/4.4/config |
|
See symfony/recipes#708 about the recipe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWB
secretsis enabled by default. After upgrading an app to 4.4, a directory is created (and checked on every request) even if I don't use this feature. Can't we just disable it by default btw?