[Serializer] fix denormalization of xml-values to objects when no xml-attributes are specified #34825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrauser
changed the title
…tional) attributes are present symfony#32144
mkrauser
force-pushed
the
4.3-issue-32114
branch
from
358de82
to
16c325c
Compare
|
Shouldn't this be handled in the XML decoder directly? |
@dunglas Wouldn't this also mean, that we always serialize and deserialize node-values using the '#'-key? Because the decoder does not know about the Model. IMHO this would be a big BC-break. |
|
Closing as this staled. Please submit again when you can! |
fabpot
added a commit
that referenced
this pull request
Apr 5, 2024
…rld) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix XML scalar to object denormalization | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #32114 #34579 | License | MIT Another approach to #34825 Commits ------- 6fe892f [Serializer] Fix XML scalar to object denormalization
symfony-splitter
pushed a commit
to symfony/serializer
that referenced
this pull request
Apr 5, 2024
…rld) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix XML scalar to object denormalization | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #32114 #34579 | License | MIT Another approach to symfony/symfony#34825 Commits ------- 6fe892f035 [Serializer] Fix XML scalar to object denormalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing an XML-Node like this to an object, everything works as expected:
<some-element optionalAttribute="foo">bar</some-element>But if all attributes are optional and missing from the node, the deserialization fails
<some-element>bar</some-element>The serializer handles XML-Attributes by prefixing them with '@' and node-data are handled with the special key '#'. But this key is only used, when attributes are present (see XmlEncoder.php#L175-185).
I choose to fix this within the denormalize-function of the AbstractObjectNormalizer. Handling it within the NameConverter would also be possible, but the NameConverter's don't know the source-format.