[Messenger] gracefully handle missing event dispatchers #34854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 6, 2019
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #34852 |
| License | MIT |
| Doc PR |
weaverryan
approved these changes
Dec 6, 2019
| @@ -39,7 +39,11 @@ class SendMessageMiddleware implements MiddlewareInterface | |||
| public function __construct(SendersLocatorInterface $sendersLocator, EventDispatcherInterface $eventDispatcher = null) | |||
| { | |||
| $this->sendersLocator = $sendersLocator; | |||
| $this->eventDispatcher = LegacyEventDispatcherProxy::decorate($eventDispatcher); | |||
|
|
|||
| if (null !== $eventDispatcher) { | |||
There was a problem hiding this comment.
maybe also add a class_exists check?
in master, could replace the contracts by PSR-14 if that makes sense btw
There was a problem hiding this comment.
I found some other places where we could make use of that too.
fabpot
approved these changes
Dec 7, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Dec 7, 2019
…abbuh) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] gracefully handle missing event dispatchers | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34852 | License | MIT | Doc PR | Commits ------- d4ae85f gracefully handle missing event dispatchers
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.