[FrameworkBundle][ContainerLintCommand] Style messages #34865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Dec 6, 2019
| $container->compile(); | ||
| try { | ||
| $container->compile(); | ||
| } catch (InvalidArgumentException $e) { |
There was a problem hiding this comment.
Should we check if the exception was thrown in CheckTypeDeclarationsPass?
fancyweb
force-pushed
the
fwb-lint-command-fail-properly
branch
2 times, most recently
from
15187b1
to
05428f2
Compare
fancyweb
requested review from
dunglas,
lyrixx,
sroze and
xabbuh
as code owners
|
I rebased on master as this is a new behavior. |
src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php
Outdated
Show resolved
Hide resolved
fabpot
added a commit
that referenced
this pull request
Dec 16, 2019
… when the kernel or the container is not supported (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][ContainerLintCommand] Improve messages when the kernel or the container is not supported | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #34865 (comment) | License | MIT | Doc PR | - Minor wording suggested here #34865 (comment) Commits ------- 6986394 [FrameworkBundle][ContainerLintCommand] Improve messages when the kernel or the container is not supported
fancyweb
force-pushed
the
fwb-lint-command-fail-properly
branch
from
05428f2
to
cb010e9
Compare
ro0NL
reviewed
Jan 2, 2020
src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
fwb-lint-command-fail-properly
branch
from
cb010e9
to
93aa5bc
Compare
fabpot
added a commit
that referenced
this pull request
Jan 7, 2020
…positive feedback on stderr (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34865 (comment) | License | MIT | Doc PR | - Outputing everything on stderr seems wrong. I'm going to check upper branches. Commits ------- 87212e4 [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr
fabpot
approved these changes
Jan 10, 2020
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Jan 10, 2020
… (fancyweb) This PR was merged into the 5.1-dev branch. Discussion ---------- [FrameworkBundle][ContainerLintCommand] Style messages | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - It gives a better feedback. Commits ------- 93aa5bc [FrameworkBundle][ContainerLintCommand] Style messages
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It gives a better feedback.