[Routing] fix memoryleak when loading compiled routes #34920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The static cache should be keyed by cache file. Otherwise, this will break things in case you have multiple router instances in the project with different config (I already saw such cases, for instance when using https://github.com/hautelook/TemplatedUriRouter in parallel of the normal router) |
|
OK, I'm tired. That's already the case. |
stof
reviewed
Dec 10, 2019
| private static function getCompiledRoutes(string $path): array | ||
| { | ||
| if ([] === self::$cache && \function_exists('opcache_invalidate') && filter_var(ini_get('opcache.enable'), FILTER_VALIDATE_BOOLEAN) && (!\in_array(\PHP_SAPI, ['cli', 'phpdbg'], true) || filter_var(ini_get('opcache.enable_cli'), FILTER_VALIDATE_BOOLEAN))) { | ||
| self::$cache = null; |
There was a problem hiding this comment.
What is the reason for disabling this memory cache when using OPCache ? Does OPCache fix the memory leak ?
There was a problem hiding this comment.
yes, opcache fixes the leak: the required data are plain arrays, which don't leak.
fabpot
approved these changes
Dec 11, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2019
…olas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [Routing] fix memoryleak when loading compiled routes | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Same as #34918 for Routing. That's the last significant memory hog I've identified. Commits ------- 85371a1 [Routing] fix memoryleak when loading compiled routes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #34918 for Routing. That's the last significant memory hog I've identified.