[FrameworkBundle][DependencyInjection] Skip removed ids in the lint container command and its associated pass #34935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
fwb-di-container-lint-dont-check-removed-ids
branch
from
89e3c76
to
07cc424
Compare
…ontainer command and its associated pass
nicolas-grekas
force-pushed
the
fwb-di-container-lint-dont-check-removed-ids
branch
from
07cc424
to
a0f581b
Compare
nicolas-grekas
approved these changes
Dec 13, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2019
… the lint container command and its associated pass (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][DependencyInjection] Skip removed ids in the lint container command and its associated pass | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34858 | License | MIT | Doc PR | - We remove the "removing" passes again and to avoid what #34502 fixed, we skip validating the "live" container removed ids in the pass (the "live" container is supposed to have the same definitions than the "debug container" one). Logically, an errored service cannot pass the "live" container compilation without being removed. Consequently, it also skips the errored services that ended up being removed in the "live" container. Commits ------- a0f581b [FrameworkBundle][DependencyInjection] Skip removed ids in the lint container command and its associated pass
fabpot
added a commit
that referenced
this pull request
Jan 7, 2020
…. services (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][ContainerLintCommand] Only skip .errored. services | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR partially reverts #34935 that was a kind of a mistake. Skipping all removed ids cannot work because all private services are in the "removed" ids. So the command ends up not validating much. To still fix the original issue #34858 we need to skip errored services. However, definition errors are not dumped / read (see #34928). So instead, even if it's bad, we can maybe rely on the name for this particular error since it's hardcoded 😕 At least it fixes this case in a simple way 😕 Commits ------- d38cdc9 [FrameworkBundle][ContainerLintCommand] Only skip .errored. services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the "removing" passes again and to avoid what #34502 fixed, we skip validating the "live" container removed ids in the pass (the "live" container is supposed to have the same definitions than the "debug container" one).
Logically, an errored service cannot pass the "live" container compilation without being removed. Consequently, it also skips the errored services that ended up being removed in the "live" container.