[Validator] Add the missing translations for the Chinese (Taiwan) ("zh_TW") locale #35064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
I'm verified this with Google Translator and all messages seem to match 👍
Thanks @Islam93 ... and congrats on your first Symfony contribution!
|
@javiereguiluz thanks! first and not last)) |
nicolas-grekas
changed the title
… (Taiwan) ("zh_TW") locale
nicolas-grekas
force-pushed
the
ticket-30197_add-missing-translations-for-zh-tw
branch
from
e0c91be
to
36f07b7
Compare
|
Thank you @Islam93. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 26, 2019
… (Taiwan) ("zh_TW") locale (Islam93)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead.
Discussion
----------
[Validator] Add the missing translations for the Chinese (Taiwan) ("zh_TW") locale
… (Taiwan) ("zh_TW") locale
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix #30197
| License | MIT
Hi
This is my first PR to the Symfony project
I saw this issue in issues list with "good first issue" mark and decided to try
I am not a native speaker of Chinese, but I ordered a translation at a translation agency. Hope it should be better than by google translator
Commits
-------
36f07b7 ticket-30197 [Validator] Add the missing translations for the Chinese (Taiwan) ("zh_TW") locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (Taiwan) ("zh_TW") locale
Hi
This is my first PR to the Symfony project
I saw this issue in issues list with "good first issue" mark and decided to try
I am not a native speaker of Chinese, but I ordered a translation at a translation agency. Hope it should be better than by google translator