[String] add test case for unwrap method #35234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
| public function testUnwrap() | ||
| { | ||
| $expected = ['hello', 'world']; | ||
| $actual = UnicodeString::unwrap([new UnicodeString('hello'), new UnicodeString('world')]); |
There was a problem hiding this comment.
One more thing: the shouldn't hardcode UnicodeString instead, the name of the class should be variable.
See the test case just below for wrap(), it does it already.
There was a problem hiding this comment.
so can i fix it or this pr is not useful ?
|
|
||
| $s = static::createFromString(''); | ||
|
|
||
| $actual = $s::unwrap(['hello', 'world']); |
There was a problem hiding this comment.
$actual = $s::unwrap([static::createFromString('hello'), static::createFromString('world')]);
There was a problem hiding this comment.
yes it's done , sorry for my mistake . It's first PR here :)
nicolas-grekas
approved these changes
Jan 6, 2020
fabpot
approved these changes
Jan 7, 2020
|
Thank you @mgamal92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just test case for
unwrap()method has been added