Fix failing CI builds on 4.4/5.0/master #35255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Jan 8, 2020
| exit; | ||
| print "*****\n"; | ||
| } | ||
|
|
||
| // get class loaders wrapped by DebugClassLoader | ||
| if ($function[0] instanceof DebugClassLoader) { | ||
| $function = $function[0]->getClassLoader(); |
There was a problem hiding this comment.
i think the offending line is here :) which returns any callable.
ro0NL
reviewed
Jan 8, 2020
| // get class loaders wrapped by DebugClassLoader | ||
| if ($function[0] instanceof DebugClassLoader) { | ||
| $function = $function[0]->getClassLoader(); |
There was a problem hiding this comment.
i would debug the actual value here first.. to see if we can understand what happened.
overall the ComposerClassLoader is not a callable/invokable type itself, so i tend to believe we need a 2nd is_array check before accessing $function[0] secondly.
mpdude
force-pushed
the
understand-test-failures
branch
from
8534cec
to
d698d23
Compare
…loader, but does not wrap a closure
mpdude
force-pushed
the
understand-test-failures
branch
from
d698d23
to
8ae1820
Compare
mpdude
changed the title
master fail
mpdude
changed the title
|
ping @nicolas-grekas, might be helpful for many people to get this resolved soon |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 8, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [Debug] fix ClassNotFoundFatalErrorHandler | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Spotted by the CI on 4.4, see #35266 for details. Replaces #35255 /cc @mpdude Commits ------- 0c320fe [Debug] fix ClassNotFoundFatalErrorHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests on
4.4andmasterseem to fail since this merge: 648544f