[FrameworkBundle] remove messenger cache if not enabled #35334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jan 14, 2020
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
Outdated
Show resolved
Hide resolved
dmaicher
force-pushed
the
remove_messenger_cache
branch
from
73307d3
to
4809b50
Compare
OskarStark
approved these changes
Jan 14, 2020
|
|
dmaicher
force-pushed
the
remove_messenger_cache
branch
from
4809b50
to
f81161d
Compare
nicolas-grekas
approved these changes
Jan 14, 2020
|
Thank you @dmaicher. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 14, 2020
…(dmaicher) This PR was merged into the 4.3 branch. Discussion ---------- [FrameworkBundle] remove messenger cache if not enabled | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes/no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> I noticed on one of my apps that I have a cache pool related to the symfony messenger integration although I'm not using the messenger at all. ``` bin/console debug:container cache.messenger.restart_workers_signal Information for Service "cache.messenger.restart_workers_signal" ================================================================ An adapter that collects data about all cache calls. ---------------- -------------------------------------------------- Option Value ---------------- -------------------------------------------------- Service ID cache.messenger.restart_workers_signal Class Symfony\Component\Cache\Adapter\TraceableAdapter Tags cache.pool kernel.reset (method: reset) Public no Synthetic no Lazy no Shared yes Abstract no Autowired no Autoconfigured no ---------------- ----------------------------------------- ``` So this PR removes the definition of the service in case the messenger integration is disabled. Commits ------- f81161d [FrameworkBundle] remove messenger cache if not enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on one of my apps that I have a cache pool related to the symfony messenger integration although I'm not using the messenger at all.
So this PR removes the definition of the service in case the messenger integration is disabled.