[HttpClient] make response stream functionality consistent #35573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @kbond. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 3, 2020
… (kbond) This PR was squashed before being merged into the 5.1-dev branch. Discussion ---------- [HttpClient] make response stream functionality consistent | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a There are three ways of creating a stream from a response: 1. Calling `$response->toStream()` (if the response supports this) 2. Calling `StreamWrapper::createResource($response)` 3. Calling `StreamWrapper::createResource($response, $httpClient)` (note the second argument) Currently, the 3rd method creates a stream that is not rewindable (the other two are). The first commit adds tests showing the inconsistencies (1 test fails). The second commit is a fix to make the 3 ways consistent. See https://twitter.com/nicolasgrekas/status/1224047079422599168 for reference. Commits ------- 64f9111 [HttpClient] make response stream functionality consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three ways of creating a stream from a response:
$response->toStream()(if the response supports this)StreamWrapper::createResource($response)StreamWrapper::createResource($response, $httpClient)(note the second argument)Currently, the 3rd method creates a stream that is not rewindable (the other two are). The first commit adds tests showing the inconsistencies (1 test fails). The second commit is a fix to make the 3 ways consistent.
See https://twitter.com/nicolasgrekas/status/1224047079422599168 for reference.