[FrameworkBundle] use framework.translator.enabled_locales to build routes' default "_locale" requirement #35590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
fwb-enabled-locales
branch
from
98b0ef6
to
1f89df7
Compare
fabpot
approved these changes
Feb 4, 2020
…outes' default "_locale" requirement
nicolas-grekas
force-pushed
the
fwb-enabled-locales
branch
from
1f89df7
to
5eebd37
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 4, 2020
…ales to build routes' default "_locale" requirement (nicolas-grekas) This PR was merged into the 5.1-dev branch. Discussion ---------- [FrameworkBundle] use framework.translator.enabled_locales to build routes' default "_locale" requirement | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - No need to configure the same requirements for `_locale` in all routes any more thanks to the `framework.translator.enabled_locales` config option introduced in #32433. Commits ------- 5eebd37 [FrameworkBundle] use framework.translator.enabled_locales to build routes' default "_locale" requirement
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to configure the same requirements for
_localein all routes any more thanks to theframework.translator.enabled_localesconfig option introduced in #32433.