Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use some PHP 5.4 constants unconditionally #35966

Merged
merged 1 commit into from Mar 5, 2020
Merged

Use some PHP 5.4 constants unconditionally #35966

merged 1 commit into from Mar 5, 2020

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Mar 5, 2020

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Since we are PHP >= 5.5.9 only, we can use those constants unconditionally.

@fancyweb fancyweb requested a review from xabbuh as a code owner March 5, 2020 09:41
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 5, 2020
@fabpot
Copy link
Member

fabpot commented Mar 5, 2020

Thank you @fancyweb.

@fabpot fabpot merged commit 600b2b5 into symfony:3.4 Mar 5, 2020
@fancyweb fancyweb deleted the use-flags-unconditionally branch March 5, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fancyweb @fabpot @nicolas-grekas @xabbuh @carsonbot