[DomCrawler] compare CrawlerSelector constraints against all matches

[m-unkel]

Q	A
Branch?	4.4+
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR

The Symfony documentation explains that...

To assert that the phrase "Hello World" is present in the page's main title, you can use this assertion:

$this->assertSelectorTextContains('html h1.title', 'Hello World');

Using native PHPUnit methods, the same assertion would look like this:

$this->assertGreaterThan( 0, $crawler->filter('html h1.title:contains("Hello World")')->count() );

..this is ONLY true if the selector has only one match.

This pull requests changes the constraint behaviour to compare all matches against the provided criteria. If this is not the desired behaviour, please fix the documentation.

[nicolas-grekas]

Can you please add some tests?

[m-unkel]

There it is! If there is anything missing please let me know.

[nicolas-grekas]

Thank you for opening. I'm closing in favor of #36158, where the discussion actually happened.