[DependencyInjection] Add a mechanism to deprecate public services to private #36470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
di-deprecate-public-service
branch
from
e080ce2
to
51e8723
Compare
fancyweb
commented
Apr 16, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/UnusedTagsPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/AliasDeprecatedPublicServicesPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/AliasDeprecatedPublicServicesPass.php
Show resolved
Hide resolved
fancyweb
force-pushed
the
di-deprecate-public-service
branch
from
51e8723
to
e1b3324
Compare
fancyweb
force-pushed
the
di-deprecate-public-service
branch
from
e1b3324
to
0df92cb
Compare
yceruto
approved these changes
Apr 30, 2020
stof
requested changes
Apr 30, 2020
src/Symfony/Component/DependencyInjection/Compiler/AliasDeprecatedPublicServicesPass.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
di-deprecate-public-service
branch
from
0df92cb
to
ff01714
Compare
stof
approved these changes
May 4, 2020
src/Symfony/Component/DependencyInjection/Compiler/AliasDeprecatedPublicServicesPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/AliasDeprecatedPublicServicesPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/AliasDeprecatedPublicServicesPass.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
di-deprecate-public-service
branch
from
ff01714
to
0a8853b
Compare
fancyweb
force-pushed
the
di-deprecate-public-service
branch
from
0a8853b
to
3e80e46
Compare
nicolas-grekas
approved these changes
May 4, 2020
|
Thank you @fancyweb. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 8, 2020
… private container to remove false-positive deprecations (nicolas-grekas) This PR was merged into the 5.1 branch. Discussion ---------- [FrameworkBundle] acces public-deprecated services via the private container to remove false-positive deprecations | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Something we missed in #36470 apparently. Commits ------- d502ba9 [FrameworkBundle] acces public-deprecated services via the private container to remove false-positive deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to easily deprecate public services to private, ie a public service will be private in a next version.
It works with a tag and a compiler pass. The pass creates a deprecated public alias of the public service.
It is ran "after removing" because we want to trigger only on direct accesses to the public service (
$container->get()): if the public service was removed, we don't need to do anything because there is no impact.All references to the public service are kept because the deprecated public alias is created afterResolveReferencesToAliasesPassso only direct access actually uses the deprecated alias.All references to the public service are altered to a direct reference to the alias target service so that they don't trigger the alias deprecation.
Thanks to @nicolas-grekas for sharing some ideas and helping me !