[Form] rework form validator tests #37104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
commented
Jun 4, 2020
| 'constraints' => [new NotBlank(['groups' => 'group1'])], | ||
| 'property_path' => '[foo]', | ||
| ]) | ||
| ->add('field2', null, [ |
There was a problem hiding this comment.
While working on #37085 I realised that we couldn't add this second field and assert its constraints are not validated. Investigating the cause for it I found out that the default ConstraintValidatorTestCase is not well suited for these kinds of tests where we cascade validation to nested fields.
xabbuh
force-pushed
the
form-validator-tests
branch
from
f19d821
to
be4151b
Compare
xabbuh
force-pushed
the
form-validator-tests
branch
2 times, most recently
from
2fbf8f5
to
f062e08
Compare
|
ping @symfony/mergers This is blocking #37103. :) |
|
This looks good to me, but Travis isn't running here, does anyone know why? |
xabbuh
force-pushed
the
form-validator-tests
branch
from
f062e08
to
a4ecec5
Compare
|
Well, it looks like yes https://travis-ci.org/github/symfony/symfony/builds/696496883, but my github UI isn't displaying it 😕 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [Form] rework form validator tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This will allow writing tests for #37103. Commits ------- f062e08 rework form validator tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow writing tests for #37103.