[FrameworkBundle] Move translation service configuration from xml to php #37186 #37258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaedl
reviewed
Jun 12, 2020
src/Symfony/Bundle/FrameworkBundle/Resources/config/translation.php
Outdated
Show resolved
Hide resolved
rvanlaak
suggested changes
Jun 12, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
| ]) | ||
| ->call('setConfigCacheFactory', [service('config_cache_factory')]) | ||
| ->tag('kernel.locale_aware') | ||
|
|
There was a problem hiding this comment.
Ahh Github, my answer was not published -_- :D
That was also my first thought but at the end i just orientated on Fabiens PR src/Symfony/Bundle/TwigBundle/Resources/config/twig.php#67.
jschaedl
approved these changes
Jun 13, 2020
Tobion
requested changes
Jun 13, 2020
| $container->services() | ||
| ->set('translator.default', Translator::class) | ||
| ->args([ | ||
| service_locator([]), // translation loaders locator |
There was a problem hiding this comment.
this should be an abstract arg as well if you use abstract_arg for the other params anyway
There was a problem hiding this comment.
Thank you for you suggestion @Tobion. I changed the call to abstract_arg
Tobion
approved these changes
Jun 15, 2020
|
Thank you @malteschlueter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move translation service configuration from xml to php