[HttpClient] always yield a LastChunk in AsyncResponse on destruction #37482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
hc-last-chunk
branch
2 times, most recently
from
2334131
to
d788104
Compare
nicolas-grekas
force-pushed
the
hc-last-chunk
branch
from
d788104
to
3a4a583
Compare
fabpot
approved these changes
Jul 3, 2020
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that async decorators always "see" the destruction of an AsyncResponse, via an
isLast()chunk + a "canceled" state.The diff is hard to read, here are the hints to understand what changed: