Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissive event dispatcher contracts for 4.4 #37503

Closed

Conversation

alexpott
Copy link
Contributor

@alexpott alexpott commented Jul 6, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

Allows the event-dispatcher component to be used on PHP 8.

@alexpott
Copy link
Contributor Author

alexpott commented Jul 6, 2020

This is not going to work...

+/home/travis/build/symfony/symfony/phpunit --exclude-group tty,benchmark,intl-data,legacy
#!/usr/bin/env php
PHP Fatal error:  Declaration of Symfony\Component\EventDispatcher\EventDispatcher::dispatch($event) must be compatible with Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch(object $event, ?string $eventName = NULL): object in /home/travis/build/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php on line 33
Fatal error: Declaration of Symfony\Component\EventDispatcher\EventDispatcher::dispatch($event) must be compatible with Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch(object $event, ?string $eventName = NULL): object in /home/travis/build/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php on line 33
KO  7.3 src/Symfony/Component/EventDispatcher 

https://travis-ci.org/github/symfony/symfony/builds/705336146

So it'd be great if #37494 can be backported to v1.

@alexpott alexpott closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants