[PropertyInfo] fix array types with keys (array<string, string>)

[digilist]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	n/a
License	MIT
Doc PR	n/a

Array types with keys are currently not detected correctly from the PropertyInfo component:

@var array<string, string>
@var array<string, array<integer, string>>

Those are currently identified as object with class rray<string, string>.

This PR tries to fix it.

What I noticed while fixing this, is that union types in arrays are not supported in general at the moment, because the Type class supports only one collectionValueType and I do not see how to pass a Union Type there. But I guess that's a different issue and for those types I decided to return null as collection value type for now. (Or better throw on exception?)

[digilist]

this code was never executed. in case of a mixed[] type on the variable, $docType was array, so I removed this code.

[digilist]

I just noticed that the build is failing for older PHP versions, please let me check first.

Update: Fixed it. It was because older versions of the phpdocumenter reflection package did not allow/parse spaces in array<string, string> The appveyor and travis builds are still red, but those builds are failing because of unrelated tests.

[nicolas-grekas]

We would consider this as a new feature indeed. Can you rebase and target master please?

[MaSpeng]

How is the status of this merge request, I stumbled over this issue by myself right now?

[nicolas-grekas]

/cc @dunglas could you maybe have a look?

[fabpot]

Thank you @digilist.

[ghost]

Hello, is there a known workaround to wait to next property-info patch release?

[pl-github]

Hello, is there a known workaround to wait to next property-info patch release?

We used object<string, MyOwnClass> instead of array<string, MyOwnClass> in our ApiPlatform project as a workaround. I know it is very crappy and phpstan does not like it either, but it is the easiest way to bridge the time until the next minor release.

[Marmelatze]

You can use something like this:

@var MyOwnClass[]
@phpstan-var array<string, MyOwnClass>

That should satisfy phpstan and the serializer.

[pl-github]

@Marmelatze Thank you for your suggestion.

The phpstan annotation works, but the normal @var annotation does not work, because the unfixed PropertyInfo version enforces arrays with a numeric index and the ArrayDenormalizer fails.

[aso824]

You could use @var aarray<string, MyOwnClass> which is also ugly hack but works with ArrayDenormalizer.

[mdeboer]

You could use @var aarray<string, MyOwnClass> which is also ugly hack but works with ArrayDenormalizer.

Thank you, this worked perfectly! Looking forward to the 5.2 release though!