[Form] Fix custom formats deprecation with HTML5 widgets

[fancyweb]

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	#37698
License	MIT
Doc PR	-

1. The options resolver only show the deprecations for user defined (overidden) options.
2. The default value of the html5 option is enough to pass the logical condition of the callback.

That means that only setting the format option (like in the reproducer) does not trigger the deprecation while it should. I think we need a feature in the options resolver component to handle those kind of cases 🤷‍♂️

Meanwhile, we can fix the issue by "deprecating" all the concerned options of the logical condition of the callback.

[fancyweb]

Looking at the failing tests I just noticed I did not fix all cases yet. Before putting more efforts in, what do you think of the proposed solution @xabbuh?

[nicolas-grekas]

@fancyweb up to move this forward?
@xabbuh any comment?

[xabbuh]

@fancyweb Isn't the test just failing because of the bug you are fixing here? I mean the test does not set the html5 option and thus now the deprecation is properly triggered which wasn't the case before while it should have been.

[fabpot]

@fancyweb Can you have a look at the last comment?

[fancyweb]

@xabbuh I finally took the time to look at this and you were right. I set the html5 option to false on the failing test.

[fabpot]

Thank you @fancyweb.