[RateLimiter] Fix minor issue when sharing windows between Limiters #38566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
requested changes
Oct 14, 2020
|
Thank you. I've updated the PR |
wouterj
approved these changes
Oct 14, 2020
nicolas-grekas
changed the title
nicolas-grekas
changed the title
|
Thank you @Nyholm. |
nicolas-grekas
force-pushed
the
share-window
branch
from
6f4a5a3
to
e9ac971
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Oct 14, 2020
…olm) This PR was squashed before being merged into the 5.x branch. Discussion ---------- Fix minor issue when sharing windows between Limiters | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | If I start using my custom Limiter, then change back to `FixedWindowLimiter`, then my cache might contain a value that `FixedWindowLimiter` does not support. This PR makes sure that we handle such switch. Commits ------- e9ac971 Fix minor issue when sharing windows between Limiters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I start using my custom Limiter, then change back to
FixedWindowLimiter, then my cache might contain a value thatFixedWindowLimiterdoes not support.This PR makes sure that we handle such switch.