Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Semaphore] Reset Key lifetime time before we acquire it #38581

Merged
merged 1 commit into from Oct 15, 2020
Merged

[Semaphore] Reset Key lifetime time before we acquire it #38581

merged 1 commit into from Oct 15, 2020

Conversation

jderusse
Copy link
Member

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets /
License MIT
Doc PR /

This is the same issue fixed by #38553 but for Semaphore component.

@derrabus derrabus added this to the 5.2 milestone Oct 15, 2020
@lyrixx
Copy link
Member

lyrixx commented Oct 15, 2020

It was on my todo list :) You were faster than me 👍🏼

Thanks

Nyholm
Nyholm requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Just a minor

src/Symfony/Component/Semaphore/Tests/SemaphoreTest.php Show resolved Hide resolved
@Nyholm
Copy link
Member

Nyholm commented Oct 15, 2020

Cool. Thank you.
I'll try to merge this now.

@Nyholm
Copy link
Member

Nyholm commented Oct 15, 2020

Thanks for fixing this bug Jérémy.

1 similar comment
@Nyholm
Copy link
Member

Nyholm commented Oct 15, 2020

Thanks for fixing this bug Jérémy.

@Nyholm Nyholm merged commit 1e89169 into symfony:5.x Oct 15, 2020
@jderusse jderusse deleted the fix-expiring branch October 25, 2020 19:49
@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Bug Semaphore Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jderusse @lyrixx @Nyholm @derrabus @carsonbot