[Lock][Semaphore] Add Factory::createFromKey and deprecate lock.store services #38593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
lock-deprecat
branch
from
55a1504
to
91fa3e3
Compare
fabpot
approved these changes
Oct 16, 2020
|
Thank you @jderusse. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | yes
| Tickets | /
| License | MIT
| Doc PR | todo
The
lockservice and aliases have been deprecated in #38576. This PR also deprecate thelock.storeservice and aliases.People should always inject the factory into their services, except for one scenario: When they want building the
Lockmanually because they want to keep the key.This scenario require declaring
lock.storeservice andPersisingStoreInterfacealiases.This could be avoided if people had a method to create a lock from a given key.
This PR adds a
LockFactory::createFromKey()method and deprecate alllock.storeservicesI also updated the Semaphore component for consistency, and helping people to only inject the SemahoreFactory.
nb: use cases for serializing the keys: