[Messenger] Do not call getQueueUrl when the url is known in AmazonSqs transport #38850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
changed the title
jderusse
force-pushed
the
sqs-queue-url
branch
from
8f19277
to
a393566
Compare
jderusse
force-pushed
the
sqs-queue-url
branch
from
a393566
to
f1f44d4
Compare
chalasr
approved these changes
Oct 29, 2020
fabpot
approved these changes
Nov 4, 2020
|
Thank you @jderusse. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user provides a DSN that looks like a queueUrl, we don't need to call the
getQueueUrlmethod. This PR inject the known queueUrl and prevent performing a useless call to the API when sending a message