[Notifier] Introduce LengthException

[OskarStark]

Q	A
Branch?	5.x
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	---
License	MIT
Doc PR	---

Follows https://github.com/symfony/symfony/pull/39444/files#r542298086

[jderusse]

I don't see the benefit over an \InvalidArgumentException. :/

IMHO not all checks require a dedicated exception class.

[derrabus]

I tend to agree with @jderusse. Can you elaborate why we need a dedicated exception here?

[OskarStark]

It was proposed by @chalasr and confirmed by @nicolas-grekas and I felt it makes sense... so... 🤔

[chalasr]

Specific exceptions allow for more fine-grained error handling. But both are fine here, I don't really care tbh :)

[ogizanagi]

Specific exceptions for logic exceptions don't really make sense to me, appart from normalizing error messages across the codebase.
Actually, I think most of the LogicException in components aren't useful when it doesn't perform any common logic to format the message, nor brings more semantics in the class name, if no native PHP exception matches . I guess we could just use native \LengthException here.

[stof]

@chalasr but invalid DSNs are not things that you should handle by catching exceptions IMO. You should instead fix your config to provide a valid DSN.

[OskarStark]

@stof its not about an invalid DSN in this case, its about a dynamic subject length of a message

[OskarStark]

Specific exceptions for logic exceptions don't really make sense to me, appart from normalizing error messages across the codebase.

@ogizanagi please keep in mind, that new bridges will come from different people and I want to make it more and more easier to implement new ones.

[nicolas-grekas]

Works for me.

[ogizanagi]

Thank you @OskarStark.