Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Use ::class keyword when possible #39775

Merged
merged 1 commit into from
Jan 11, 2021
Merged

[WIP] Use ::class keyword when possible #39775

merged 1 commit into from
Jan 11, 2021

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jan 10, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

@carsonbot carsonbot added this to the 4.4 milestone Jan 10, 2021
@fabpot fabpot changed the title Use ::class keyword when possible [WIP] Use ::class keyword when possible Jan 10, 2021
@xabbuh
Copy link
Member

xabbuh commented Jan 10, 2021

I was thinking about this as well. Can we update fabbot to enforce the usage of the class constant?

@fabpot
Copy link
Member Author

fabpot commented Jan 10, 2021

@xabbuh That's probably the job of PHP CS Fixer, and it's not trivial, see PHP-CS-Fixer/PHP-CS-Fixer#2918 for reference

@fabpot fabpot force-pushed the class-keyword branch 3 times, most recently from 0e7634d to 2e223e6 Compare January 10, 2021 16:24
@derrabus
Copy link
Member

Merging this up is going to be a huge one-time PITA, but I think we'll have a nicer codebase afterwards.

@fabpot
Copy link
Member Author

fabpot commented Jan 10, 2021

I will merge this one up. My strategy with such a PR is always the following: merge everything up, then merge the PR, merge up again and ignore all conflicts. Start again the work on branch n + 1, rinse and repeat.

@fabpot fabpot merged commit c79e61f into symfony:4.4 Jan 11, 2021
@fabpot fabpot deleted the class-keyword branch January 11, 2021 06:03
@simonberger simonberger mentioned this pull request Jan 25, 2021
Merged
hultberg pushed a commit to hultberg/symfony that referenced this pull request Sep 17, 2021
@fabpot
minor symfony#39775 [WIP] Use ::class keyword when possible (fabpot)
a786641 
This PR was merged into the 4.4 branch.

Discussion
----------

[WIP] Use ::class keyword when possible

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a  <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

036a36c Use ::class keyword when possible
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
@fabpot
minor symfony#39775 [WIP] Use ::class keyword when possible (fabpot)
50a58e0 
This PR was merged into the 4.4 branch.

Discussion
----------

[WIP] Use ::class keyword when possible

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a  <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

036a36c Use ::class keyword when possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabpot @xabbuh @derrabus @carsonbot