[Console] fix QuestionHelper::getHiddenResponse() not working with space in project directory name #40192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seb33300
reviewed
Feb 15, 2021
|
Do you think it is possible to add a test for this feature? That would make sure we never reintroduce this bug again. |
nicolas-grekas
changed the title
nicolas-grekas
approved these changes
Feb 16, 2021
|
@Nyholm Adding a test case is going to be tricky as this means installing the package in a directory with a space before launching the tests. We cannot isolate this in a simple test case... |
chalasr
approved these changes
Feb 16, 2021
…ace in project directory name
chalasr
requested review from
dunglas,
jderusse,
lyrixx,
sroze,
wouterj,
xabbuh and
yceruto
as code owners
|
Thank you @Yendric. |
|
I understand that writing a test for this is tricky (I don't know how). I was hoping for someone to come up with a genius idea =) Thank you @Yendric for this PR and congratulations for your first contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40190 to allow spaces in project directory name.