[Workflow] Deprecate InvalidTokenConfigurationException #40202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Feb 15, 2021
chalasr
commented
| Q | A |
|---|---|
| Branch? | 5.x |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Tickets | - |
| License | MIT |
| Doc PR | - |
lyrixx
approved these changes
Feb 15, 2021
|
Thank you @chalasr. |
| @@ -11,10 +11,14 @@ | |||
|
|
|||
| namespace Symfony\Component\Workflow\Exception; | |||
|
|
|||
| trigger_deprecation('symfony/workflow', '5.3', sprintf('The "%s" class is deprecated.', InvalidTokenConfigurationException::class)); | |||
There was a problem hiding this comment.
While checking the doc issue for this (symfony/symfony-docs#14987) I found this PR. I think we should always include an alternative in the deprecation messages.
If the developer sees just this message -> "The InvalidTokenConfigurationException class is deprecated." they don't know what to do. OK, it's deprecated but ... is there a new class that replaces it? Is this gone for good without an alternative?
Thanks!
There was a problem hiding this comment.
Yes it's gone. This exception is not thrown anymore by symfony.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.