Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Allow x-forwarded-prefix trusted header in config #40281

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[FrameworkBundle] Allow x-forwarded-prefix trusted header in config #40281

merged 1 commit into from
Feb 23, 2021

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Feb 23, 2021

Q A
Branch? 5.2 (as requested by @nicolas-grekas)
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Support for X_FORWARDED_PREFIX has been added in PR #37734.

However, it is impossible to use it because the configuration doesn't allow the x-forwarded-prefix value in framework.yaml.

@carsonbot carsonbot changed the title Allow x-forwarded-prefix trusted header. [FrameworkBundle] Allow x-forwarded-prefix trusted header. Feb 23, 2021
@derrabus derrabus changed the title [FrameworkBundle] Allow x-forwarded-prefix trusted header. [FrameworkBundle] Allow x-forwarded-prefix trusted header Feb 23, 2021
@derrabus
Copy link
Member

The PR targets the 5.x branch. It should target 5.2 instead.

@nicolas-grekas nicolas-grekas changed the base branch from 5.x to 5.2 February 23, 2021 15:56
@nicolas-grekas nicolas-grekas changed the base branch from 5.2 to 5.x February 23, 2021 15:57
@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] Allow x-forwarded-prefix trusted header [FrameworkBundle] Allow x-forwarded-prefix trusted header in config Feb 23, 2021
@nicolas-grekas nicolas-grekas changed the base branch from 5.x to 5.2 February 23, 2021 15:58
@nicolas-grekas
Copy link
Member

Thank you @drupol.

@nicolas-grekas nicolas-grekas merged commit 5028aaf into symfony:5.2 Feb 23, 2021
@drupol drupol deleted the allow-x-forwarded-prefix branch February 23, 2021 15:58
@fabpot fabpot mentioned this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants