[Security] Rename User to InMemoryUser

[chalasr]

Q	A
Branch?	5.x
Bug fix?	no
New feature?	yes
Deprecations?	yes
Tickets	Closes #26348
License	MIT
Doc PR	-

This PR aims to clarify that the User class should only be used by the InMemoryUserProvider, as documented:

symfony/src/Symfony/Component/Security/Core/User/User.php

Lines 15 to 17 in c06a76c

	* User is the user implementation used by the in-memory user provider.
	*
	* This should not be used for anything else.

It also renames UserChecker to InMemoryUserChecker because it only works with the in-memory user class:

symfony/src/Symfony/Component/Security/Core/User/UserChecker.php

Lines 31 to 32 in c06a76c

	if (!$user instanceof User) {
	return;

[chalasr]

The travis failure with deps=high is expected. This is ready

[chalasr]

Thanks for the review @rosier, all comments have been addressed.

[fabpot]

What about NOT supporting the deprecated stuff in the new class?

[chalasr]

Given this makes the security.user_checker service use the new class, not supporting those checks would be a behavior change. As this is about security and all is done via configuration (you don't need to manipulate those classes to use them), I think it's worth keeping those checks until 6.0

[wouterj]

Thanks Robin!

Am I missing something, or are the 2 src/Symfony/Component/Security/Core/Tests/Authentication/Token/Fixtures/switch-user-token-*.txt files not used?

[wouterj]

Sorry, I selected the wrong choice 🤦

[chalasr]

Am I missing something, or are the 2 src/Symfony/Component/Security/Core/Tests/Authentication/Token/Fixtures/switch-user-token-*.txt files not used?

Only one of two, actually! It's used in SwitchUserListenerTest.

Thanks for the review Wouter, all fixed.

[fabpot]

Are the broken tests related to the changes here?

[chalasr]

@fabpot yes but only deps=high fails, I think it will be fixed once merged.
In case I'm wrong, be sure that I'll send a PR to fix it right away.

[fabpot]

Thank you @chalasr.