[DependencyInjection] Add support of PHP enumerations #40857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
feat-dependency-injection-enum-support
branch
2 times, most recently
from
78c44fb
to
9d8fa01
Compare
|
Hey! I think @atailouloute has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
stloyd
reviewed
Apr 19, 2021
stof
reviewed
Apr 19, 2021
src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Dumper/YamlDumper.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
feat-dependency-injection-enum-support
branch
2 times, most recently
from
2ff81ae
to
d3e9060
Compare
derrabus
requested changes
Apr 19, 2021
src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
feat-dependency-injection-enum-support
branch
from
d3e9060
to
c4adfe1
Compare
alexandre-daubois
changed the title
alexandre-daubois
force-pushed
the
feat-dependency-injection-enum-support
branch
from
6abf811
to
40ababd
Compare
stof
approved these changes
Jun 4, 2021
|
@nicolas-grekas @fabpot should this be merged in 4.4 as it is about supporting a new PHP version ? |
xabbuh
reviewed
Jun 6, 2021
| @@ -127,6 +127,8 @@ public static function dump($value, int $flags = 0): string | |||
| return self::dumpNull($flags); | |||
| case $value instanceof \DateTimeInterface: | |||
| return $value->format('c'); | |||
| case $value instanceof \UnitEnum: | |||
There was a problem hiding this comment.
if we add new things in the Yaml component, I'd really appreciate to add some tests there covering this kind of feature
There was a problem hiding this comment.
Added one here. Not sure if there's another one to add? This one should be enough if I'm right.
derrabus
reviewed
Jun 6, 2021
| @@ -127,6 +127,8 @@ public static function dump($value, int $flags = 0): string | |||
| return self::dumpNull($flags); | |||
| case $value instanceof \DateTimeInterface: | |||
| return $value->format('c'); | |||
| case $value instanceof \UnitEnum: | |||
There was a problem hiding this comment.
Do we need to adjust the DI component's composer.json?
There was a problem hiding this comment.
I don't think so, the current composer.json seems good with "^4.4|^5.0"
alexandre-daubois
force-pushed
the
feat-dependency-injection-enum-support
branch
from
40ababd
to
5248a43
Compare
alexandre-daubois
force-pushed
the
feat-dependency-injection-enum-support
branch
from
5248a43
to
1a36bef
Compare
alexandre-daubois
force-pushed
the
feat-dependency-injection-enum-support
branch
from
1a36bef
to
1c43829
Compare
alexandre-daubois
force-pushed
the
feat-dependency-injection-enum-support
branch
2 times, most recently
from
8bb428a
to
bb4eb0d
Compare
alexandre-daubois
force-pushed
the
feat-dependency-injection-enum-support
branch
from
bb4eb0d
to
8f29ff3
Compare
nicolas-grekas
approved these changes
Jun 22, 2021
nicolas-grekas
force-pushed
the
feat-dependency-injection-enum-support
branch
from
8f29ff3
to
88c69c0
Compare
|
Thank you @alexandre-daubois. |
This was referenced Jun 30, 2021
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Feb 4, 2022
…num as parameters (ogizanagi) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [DependencyInjection][FrameworkBundle] Fix using PHP 8.1 enum as parameters | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yesish | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #44834 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | N/A While #40857 allowed using enums in DI, it does not allow using these in parameters. This would be the actual fix for #44834, which shows the error you'll get trying to use enum as DI parameters (appart from the binding issue fixed in #44838):  given: ```php namespace App; enum Status { case Draft; case Deleted; case Published; } ``` ```yaml # services.yaml parameters: default_status: !php/const App\Status::Draft ``` The exception happens because the `PhpDumper` misses the leading slash: ```diff protected function getDefaultParameters(): array { return [ - 'default_status' => App\Status::Draft, + 'default_status' => \App\Status::Draft, ]; } ``` While this would fix using enums as DI parameters as of Symfony < 6, the `ParameterBagInterface::get/set` and `ContainerInterface::setParameter/getParameter` are not allowing `\UnitEnum` and adding these in phpdoc is an issue since actual typehints and return types were added as of Symfony 6. => So this PR is a BC break, but hopefully nobody will be hit by it 🤞🏻 (poke `@ismail1432` - https://twitter.com/SmaineDev/status/1476237072826613763?s=20) Commits ------- ac36617 [DependencyInjection][FrameworkBundle] Fix using PHP 8.1 enum as parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of enums using
!php/consttag, as they work the same way.