[PhpUnitBridge] Fix tests with @doesNotPerformAssertions annotations
#40957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
|
Hey! I think @fancyweb has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
OskarStark
changed the title
@doesNotPerformAssertions annotations
OskarStark
reviewed
Apr 29, 2021
src/Symfony/Bridge/PhpUnit/Tests/FailTests/NoAssertionsTestRisky.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 29, 2021
src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 29, 2021
nicolas-grekas
requested review from
chalasr,
dunglas,
lyrixx,
wouterj,
xabbuh and
yceruto
as code owners
|
Thank you @alexpott. |
nicolas-grekas
force-pushed
the
fix-doesNotPerformAssertions
branch
from
4afe2d0
to
4ad1232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test uses the
@doesNotPerformAssertionsand also has the Symfony Deprecation listener enabled because it is using the trait as well then this does not work as expected. Currently the bridge is checking this annotation/setting prior to running the test. This results in:$this->expectNotToPerformAssertions()is called during a test$test->getTestResultObject()->beStrictAboutTestsThatDoNotTestAnything(false);