Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notifier] Fix return SentMessage then Messenger not used #40982

Merged
merged 1 commit into from May 7, 2021
Merged

[Notifier] Fix return SentMessage then Messenger not used #40982

merged 1 commit into from May 7, 2021

Conversation

WaylandAce
Copy link
Contributor

@WaylandAce WaylandAce commented Apr 29, 2021 •
edited

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets --
License MIT
Doc PR --

#37748 Broke the Notifier when Transport not used.

@OskarStark
Copy link
Contributor

@jschaedl can you please have a look?

@jschaedl
Copy link
Contributor

@WaylandAce Can you please target 5.2 branch and make fabbot.io happy :-)

@OskarStark OskarStark added this to the 5.2 milestone Apr 29, 2021
@WaylandAce WaylandAce changed the base branch from 5.x to 5.2 April 29, 2021 16:45
@derrabus
Copy link
Member

derrabus commented May 2, 2021

I think we should add a test, so we don't break this again.

@WaylandAce WaylandAce force-pushed the fix/notifier_null_sentmessage branch from f8bf59c to c288bb7 Compare May 5, 2021 08:20
@WaylandAce WaylandAce force-pushed the fix/notifier_null_sentmessage branch from c288bb7 to 9a2526d Compare May 5, 2021 09:03
@WaylandAce WaylandAce force-pushed the fix/notifier_null_sentmessage branch 4 times, most recently from 0e13d25 to 81a0dc5 Compare May 6, 2021 07:29
@WaylandAce WaylandAce force-pushed the fix/notifier_null_sentmessage branch from 81a0dc5 to 4197af2 Compare May 6, 2021 16:53
jschaedl
jschaedl approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@jschaedl jschaedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 minor issues. The rest looks good to me 👍🏻

@WaylandAce WaylandAce force-pushed the fix/notifier_null_sentmessage branch from 4197af2 to 82085de Compare May 7, 2021 05:11
@WaylandAce WaylandAce force-pushed the fix/notifier_null_sentmessage branch from 82085de to 1245114 Compare May 7, 2021 06:30
OskarStark
OskarStark requested changes May 7, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we can merge this PR, please add MIT to the License in the PR header, this should make Fabbot happy.

Thanks

OskarStark
OskarStark approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LICENSE added 👍

@OskarStark
Copy link
Contributor

Thank you Pavel for taking care of this regression.

@OskarStark OskarStark merged commit ca46f10 into symfony:5.2 May 7, 2021
This was referenced May 9, 2021
Merged
Merged
@OskarStark OskarStark mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@jschaedl jschaedl jschaedl approved these changes

Assignees
No one assigned
Labels
Bug Notifier Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@WaylandAce @OskarStark @jschaedl @derrabus @fabpot @carsonbot