[String] add types to all arguments #41428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
May 28, 2021
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 6 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas
force-pushed
the
unions-string
branch
from
fdf76e9
to
17165f9
Compare
nicolas-grekas
force-pushed
the
unions-string
branch
from
17165f9
to
4fea19d
Compare
derrabus
reviewed
May 28, 2021
| return parent::endsWith($suffix); | ||
| } else { | ||
| $suffix = (string) $suffix; |
There was a problem hiding this comment.
This change removes support for Stringable objects, doesn't it?
There was a problem hiding this comment.
See the added type hint: no Stringable object can get through it.
Ppl that use strict types might be affected, but strict types aren't covered by our BC promise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.