[Serializer] Do not allow to denormalize string with spaces only to valid a DateTime object #41491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jun 1, 2021
derrabus
approved these changes
Jun 1, 2021
ro0NL
reviewed
Jun 2, 2021
src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php
Outdated
Show resolved
Hide resolved
ro0NL
reviewed
Jun 2, 2021
src/Symfony/Component/Serializer/Tests/Normalizer/DateTimeNormalizerTest.php
Outdated
Show resolved
Hide resolved
|
Please check tests as they're failing right now. |
sidz
force-pushed
the
do-not-allow-to-denormalize-string-with-spaces
branch
from
7f3cc19
to
f6ab2bf
Compare
|
@nicolas-grekas done |
ro0NL
approved these changes
Jun 3, 2021
| @@ -97,7 +97,7 @@ public function denormalize($data, $type, $format = null, array $context = []) | |||
| $dateTimeFormat = $context[self::FORMAT_KEY] ?? null; | |||
| $timezone = $this->getTimezone($context); | |||
|
|
|||
| if ('' === $data || null === $data) { | |||
| if (null === $data || (\is_string($data) && '' === trim($data))) { | |||
There was a problem hiding this comment.
well this change a lot but exception message says:
The data is either an empty string or null, you should pass a string that can be parsed with the passed format or a valid DateTime string.
|
Thank you @sidz. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 4, 2021
…s only to valid a DateTime object (sidz) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Serializer] Do not allow to denormalize string with spaces only to valid a DateTime object | Q | A | ------------- | --- | Branch? |4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT This PR fixes an issue when `$data` variable contains only spaces. In this case DateTimeNormalizer creates a DateTime object. Commits ------- 21c0829 [Serializer] Do not allow to denormalize string with spaces only to valid a DateTime object
|
Looks like something went wrong in the merge process. I'm closing the PR but no worries, the merge did happen 3524cf2. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when
$datavariable contains only spaces. In this case DateTimeNormalizer creates a DateTime object.