[FrameworkBundle] fix KernelBrowser::loginUser with a stateless firewall #41505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Jun 1, 2021
derrabus
approved these changes
Jun 1, 2021
|
Thank you @dunglas. |
| $session = $this->getContainer()->get('session'); | ||
|
|
||
| $container = $this->getContainer(); | ||
| $container->get('security.token_storage')->setToken($token); |
There was a problem hiding this comment.
replaced by security.untracked_token_storage in b004f3b
There was a problem hiding this comment.
Oops sorry I totally forgot about the existence of this service. Thanks!
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
KernelBrowser::loginUser()doesn't work with stateless firewalls (Basic HTTP, JWT etc) and fails if the session is disabled (which is frequent when creating web APIs, and when using stateless firewalls). This PR fixes the problem.