[MonologBridge] Fixed the WebProcessor #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebProcessor can now be registered as a kernel.request listener to get the request instead of passing it as a constructor argument, which was broken as the request is not yet available when the logger is instantiated.
fabpot
added a commit
that referenced
this pull request
Apr 29, 2012
Commits ------- 689a40d [MonologBridge] Fixed the WebProcessor Discussion ---------- [MonologBridge] Fixed the WebProcessor The WebProcessor can now be registered as a kernel.request listener to get the request instead of passing it as a constructor argument, which was broken as the request is not yet available when the logger is instantiated. I'm sending it to 2.0 even if the way to use the processor is not BC as this is really a bugfix. The processor was simply unusable with the previous way. Tell me if you think it should only be fixed for 2.1 Fixes #3311
|
Tests broke. |
|
👍 (minus the test breakage;) |
|
I indeed forgot to update the test to set request through the setter. Unfortunately, I'm on a McDonald's connection currently (which allows me to do some stoffing) and I cannot use SSH to push new changes (this branch was in my repo since a few days but I forgot to send the PR) |
|
@stof: Can you fix the tests please? |
|
This is an old fix but the documentation is needed on how to use Web Processor behind Load Balancer, where serverData['REMOTE_ADDR'] may not return the correct IP, right ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebProcessor can now be registered as a kernel.request listener to
get the request instead of passing it as a constructor argument, which
was broken as the request is not yet available when the logger is
instantiated.
I'm sending it to 2.0 even if the way to use the processor is not BC as this is really a bugfix. The processor was simply unusable with the previous way. Tell me if you think it should only be fixed for 2.1
Fixes #3311