[Doctrine Bridge] Added a method to load a cache definition #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this PR. |
|
👍 |
| * | ||
| * @param array $objectManager A configured object manager. | ||
| * @param ContainerBuilder $container A ContainerBuilder instance | ||
| * @param string $cacheName |
There was a problem hiding this comment.
You should note that you throw \InvalidArgumentException in case of unknown driver.
|
Can you add a note abou this change in the CHANGELOG? |
|
does it really need to be in the changelog ? End-users don't know about this at all. The only guys affected by this change are the maintainers of the different Doctrine bundles as they can remove some code now. |
|
@fabpot : done |
|
@bamarni can you also do a patch for the docs after this gets merged so that people know about this change and know how to use it? Thank you! |
|
@dlsniper : no problem ;) |
|
ping @beberlei |
fabpot
added a commit
that referenced
this pull request
May 10, 2012
Commits ------- a2b3d3c added cache service definition Discussion ---------- [Doctrine Bridge] Added a method to load a cache definition Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - Following this discussion (doctrine/DoctrineBundle#62), this will let DoctrineBundle, MongodbBundle and CouchdbBundle share the same code for cache definitions. --------------------------------------------------------------------------- by dlsniper at 2012-04-30T06:56:49Z +1 for this PR. --------------------------------------------------------------------------- by stof at 2012-04-30T06:57:58Z :+1: --------------------------------------------------------------------------- by fabpot at 2012-04-30T15:41:05Z Can you add a note abou this change in the CHANGELOG? --------------------------------------------------------------------------- by stof at 2012-04-30T15:46:48Z does it really need to be in the changelog ? End-users don't know about this at all. The only guys affected by this change are the maintainers of the different Doctrine bundles as they can remove some code now. --------------------------------------------------------------------------- by fabpot at 2012-04-30T16:41:21Z @stof: right @bamarni: Can you squash your commits? --------------------------------------------------------------------------- by bamarni at 2012-04-30T17:03:38Z @fabpot : done --------------------------------------------------------------------------- by dlsniper at 2012-04-30T17:22:07Z @bamarni can you also do a patch for the docs after this gets merged so that people know about this change and know how to use it? Thank you! --------------------------------------------------------------------------- by bamarni at 2012-04-30T17:29:05Z @dlsniper : no problem ;) --------------------------------------------------------------------------- by fabpot at 2012-04-30T18:29:03Z ping @beberlei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
Following this discussion (doctrine/DoctrineBundle#62), this will let DoctrineBundle, MongodbBundle and CouchdbBundle share the same code for cache definitions.