Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Fix incorrect parameter type #41621

Merged
merged 1 commit into from Jun 9, 2021
Merged

Conversation

bch36
Copy link
Contributor

@bch36 bch36 commented Jun 8, 2021

In the affected line of code, fclose() should ONLY be passed a parameter of type resource, but fopen() can return a value of type bool (if the fopen() fails). This results in a fatal error under PHP 8: Fatal error: Uncaught TypeError: fclose(): Argument #1 ($stream) must be of type resource, bool given.

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot added the Bug label Jun 8, 2021
@derrabus derrabus added this to the 4.4 milestone Jun 8, 2021
@derrabus
Copy link
Member

derrabus commented Jun 8, 2021

You've submitted the PR against the 5.4 branch, but apparently you wanted to target 4.4. Can you please rebase?

@carsonbot carsonbot changed the title Fix incorrect parameter type [Process] Fix incorrect parameter type Jun 8, 2021
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 4.4 June 9, 2021 14:52
@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 5.4 June 9, 2021 14:52
@nicolas-grekas
Copy link
Member

Thank you @bch36.

@nicolas-grekas nicolas-grekas merged commit dd2e605 into symfony:4.4 Jun 9, 2021
@fabpot fabpot mentioned this pull request Jun 17, 2021
This was referenced Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants