Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] fix Could not find service "test.service_container" #41719

Merged

Conversation

smilesrg
Copy link
Contributor

@smilesrg smilesrg commented Jun 15, 2021

Q A
Branch? 5.2, needs to be ported to 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41715
License MIT

Partial backport of #41530
Related to #41715 and #41530

When launching phpunit, got an error:
LogicException: Could not find service "test.service_container". Try updating the "framework.test" config to "true".

There was 1 error:

1) App\Symfony\Bundle\Tests\Integration\IntegrationTest::testServiceWiringWithConfiguration
LogicException: Could not find service "test.service_container". Try updating the "framework.test" config to "true".

/Projects/app/vendor/symfony/framework-bundle/Test/KernelTestCase.php:109
/Projects/app/tests/integration/IntegrationTest.php:23

Caused by
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "test.service_container". Did you mean this: "service_container"?

/Projects/app/vendor/symfony/dependency-injection/Container.php:280
/Projects/app/vendor/symfony/dependency-injection/Container.php:228
/Projects/app/vendor/symfony/framework-bundle/Test/KernelTestCase.php:107
/Projects/app/tests/integration/IntegrationTest.php:23

/cc @xabbuh @nicolas-grekas

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title bug #41715: [FrameworkBundle] Partial backport of PR#41530 [FrameworkBundle] bug #41715: Partial backport of PR#41530 Jun 15, 2021
@YaFou
Copy link
Contributor

YaFou commented Jun 16, 2021

Can you implement a test please?

@smilesrg
Copy link
Contributor Author

Can you implement a test please?

Well... this is a backport of PR that hasn't any tests... Probably I can, but I'm not sure how to test these changes properly.

@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] bug #41715: Partial backport of PR#41530 [FrameworkBundle] fix Could not find service "test.service_container" Jun 17, 2021
@nicolas-grekas
Copy link
Member

Thank you @smilesrg.

@nicolas-grekas nicolas-grekas merged commit a026c67 into symfony:5.2 Jun 17, 2021
@smilesrg smilesrg deleted the bugfix/41715-test-service-container branch June 17, 2021 13:49
@smilesrg
Copy link
Contributor Author

@nicolas-grekas Thank you too!

@fabpot fabpot mentioned this pull request Jun 17, 2021
@fabpot fabpot mentioned this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants