[Security] Fixed 'security.command.debug_firewall' not found #41747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y/console is installed
chalasr
approved these changes
Jun 19, 2021
wouterj
approved these changes
Jun 19, 2021
|
Good catch, thanks Tobias. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on a bundle that depends on some
symfony/security-bundle, I found this.Basically, we assume that service
security.command.debug_firewallis always defined. For most application this service is defined as it is defined ifsymfony/consoleis installed. This is why we never caught the bug before.But I do run into issues when I run the tests for my bundle.