[FrameworkBundle] Replace var_export with VarExporter to use array short syntax in secrets list files #41795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,8 @@ | |||
| "symfony/polyfill-mbstring": "~1.0", | |||
| "symfony/filesystem": "^3.4|^4.0|^5.0", | |||
| "symfony/finder": "^3.4|^4.0|^5.0", | |||
| "symfony/routing": "^4.4.12|^5.1.4" | |||
| "symfony/routing": "^4.4.12|^5.1.4", | |||
| "symfony/var-exporter": "^4.4|^5.0" | |||
There was a problem hiding this comment.
can be removed actually: var-exporter is already a transitive dep via symfony/cache and that won't change
There was a problem hiding this comment.
Removed, thanks for the info!
alexandre-daubois
force-pushed
the
fix-vault-list-format
branch
from
5fbf84a
to
7f1c762
Compare
derrabus
approved these changes
Jun 22, 2021
nicolas-grekas
approved these changes
Jun 22, 2021
|
Thank you @alexandre-daubois. |
This was referenced Jun 30, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using secrets a lot lately. Unfortunately, command exports the
{env}.list.phpwith the "old" array syntax usingarray(), and writingnullin uppercase.This results in tedious situations with PHP CS Fixer (for example) rewriting the whole file to restore the modern syntax, each time we add a secret.
The Sodium vault currently uses
var_export. I suggest using Symfony VarExporter, which does the work just fine. It adds a dependency to the FrameworkBundle, but it is a cleaner way to do it rather than using this type of hack IMO.