Fix SessionTokenStorage reuse with Request #41881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
reviewed
Jun 28, 2021
src/Symfony/Component/Security/Csrf/TokenStorage/SessionTokenStorage.php
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Jun 28, 2021
|
tests added |
1 similar comment
|
tests added |
derrabus
approved these changes
Jun 29, 2021
fabpot
approved these changes
Jun 30, 2021
|
Thank you @jderusse. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CsrfTokenManager is used BEFORE a request is sent, the
SessionTokenStoragecreates a fake session to stores the token.But if the Storage is, then, called with a real request, the fake session is not used anymore. This is an issue for people using CSRF tests in tests. Asm they are not able to use the
security.csrf.token_managerservice.