Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filesystem] Workaround cannot dumpFile into "protected" folders on Windows #41893

Merged
merged 1 commit into from Jun 30, 2021

Conversation

arnegroskurth
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39496
License MIT
Doc PR

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@arnegroskurth arnegroskurth changed the title WIP Fix: [Filesystem] Cannot dumpFile into "protected" folders on Windows Jun 29, 2021
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the change, the error message will change, that's the only side effect

@nicolas-grekas nicolas-grekas changed the title Fix: [Filesystem] Cannot dumpFile into "protected" folders on Windows [Filesystem] Workaround cannot dumpFile into "protected" folders on Windows Jun 29, 2021
@carsonbot carsonbot closed this Jun 29, 2021
@nicolas-grekas nicolas-grekas marked this pull request as ready for review June 29, 2021 09:54
@carsonbot carsonbot added this to the 4.4 milestone Jun 29, 2021
@fabpot
Copy link
Member

fabpot commented Jun 30, 2021

Thank you @arnegroskurth.

@fabpot fabpot merged commit e2d33fb into symfony:4.4 Jun 30, 2021
This was referenced Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants