[Security] Deprecate TokenInterface::isAuthenticated()
#42050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
deprecate-unauthenticated-tokens
branch
13 times, most recently
from
f4497d8
to
4cfcf3d
Compare
chalasr
force-pushed
the
deprecate-unauthenticated-tokens
branch
from
4cfcf3d
to
366e1e7
Compare
This comment has been minimized.
This comment has been minimized.
chalasr
force-pushed
the
deprecate-unauthenticated-tokens
branch
from
366e1e7
to
f892331
Compare
src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Firewall/ContextListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Tests/Firewall/AccessListenerTest.php
Outdated
Show resolved
Hide resolved
chalasr
force-pushed
the
deprecate-unauthenticated-tokens
branch
2 times, most recently
from
36b1a3f
to
6a2547f
Compare
|
Once a bundle provides an integration for the new authenticator system (available since 5.1, considered stable since 5.3), it really has no reason to use the API that this PR deprecates. The only way for a bundle to support both the old system and the new one is to provide two distinct implementations: For e.g. scheb/2fa or lexik/jwt-authentication-bundle, the only thing needed to be deprecation-free on both 5.x and 6.x is to replace some |
chalasr
force-pushed
the
deprecate-unauthenticated-tokens
branch
from
6a2547f
to
55cb0f6
Compare
nicolas-grekas
approved these changes
Jul 11, 2021
chalasr
force-pushed
the
deprecate-unauthenticated-tokens
branch
from
55cb0f6
to
3fe9eac
Compare
OskarStark
reviewed
Jul 13, 2021
chalasr
force-pushed
the
deprecate-unauthenticated-tokens
branch
from
3fe9eac
to
33b8fbd
Compare
derrabus
approved these changes
Jul 14, 2021
|
Thank you Robin. |
This was referenced Aug 8, 2021
fabpot
added a commit
that referenced
this pull request
Aug 13, 2021
… users, and token credentials (wouterj) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Security] Deprecate AnonymousToken, non-UserInterface users, and token credentials | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | Ref #41613, #34909 | License | MIT | Doc PR | - This is a continuation of `@xabbuh`'s experiment in #34909 and `@chalasr`'s work in #42050. This hopefully is the last cleanup of `TokenInterface`: * As tokens now always represent an authenticated user (and no longer e.g. the "username" input of the form), we can finally remove the weird `string|\Stringable` union from `Token::getUser()` and other helper methods and require a user to be an instance of `UserInterface`. * For the same reason, we can also deprecate token credentials. I didn't deprecate `Token::eraseCredentials()` as this is still used to remove credentials from `UserInterface`. * Meanwhile, this also deprecated the `AnonymousToken`, which we forgot in 5.3. This token is not used anymore in the new system (anonymous does no longer exists). This was also the only token in core that didn't fulfill the `UserInterface` requirement for authenticated tokens. Commits ------- 44b843a [Security] Deprecate AnonymousToken, non-UserInterface users, and token credentials
fabpot
added a commit
that referenced
this pull request
Sep 1, 2021
…ot an AbstractToken (chalasr) This PR was merged into the 5.4 branch. Discussion ---------- [Security] Do not deauthenticate token on user change if not an AbstractToken | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In #42050, we moved the `hasUserChanged()` logic used for deauthentication from AbstractToken to ContextListener. Problem is that this check is now done against on all kind of tokens, whereas it was only for `AbstractToken` instances before. That breaks https://github.com/scheb/2fa, tokens get wrongly deauthenticated in the middle of the 2fa auth process. This fixes it by skipping non-AbstractToken implementations. We may want to provide a way to opt-in/out the `hasUserChanged()` logic on a custom token with e.g. a marker interface, but that's not necessarily worth it for now IMHO. Commits ------- fe31fcb [Security] Do not deauthenticate token on user change if not an AbstractToken
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #41613 (comment)