Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notifier] [Smsapi] fixed checking whether message is sent #42053

Merged
merged 1 commit into from Aug 26, 2021
Merged

[Notifier] [Smsapi] fixed checking whether message is sent #42053

merged 1 commit into from Aug 26, 2021

Conversation

damlox
Copy link
Contributor

@damlox damlox commented Jul 10, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

SmsAPI always return 200 status code even if we enter incorrect token.
The content is: {"error":101,"message":"Authorization failed"}.

@damlox damlox requested a review from OskarStark as a code owner July 10, 2021 19:03
@carsonbot carsonbot added this to the 5.3 milestone Jul 10, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

OskarStark
OskarStark reviewed Jul 10, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case

@carsonbot carsonbot changed the title fixed checking whether message is sent [Notifier] fixed checking whether message is sent Jul 10, 2021
@OskarStark OskarStark changed the title [Notifier] fixed checking whether message is sent [Notifier] [Smsapi] fixed checking whether message is sent Jul 10, 2021
@OskarStark OskarStark requested a review from jderusse July 13, 2021 19:12
jderusse
jderusse reviewed Jul 13, 2021
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransport.php Outdated

throw new TransportException(sprintf('Unable to send the SMS: "%s".', $error['message']), $response);
if ((isset($responseContent['error']) && null !== $responseContent['error']) || (200 !== $response->getStatusCode())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isset($foo['bar']) returns also true when the key exists but it's value is null.
You can remove the second assertion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to confirm if the value is not null. Checking only if the key exists is not sufficient

@OskarStark
Copy link
Contributor

OskarStark commented Jul 28, 2021 •
edited

I would really appreciate if you finish this PR and apply the comments. Thanks

@damlox
Copy link
Contributor Author

damlox commented Jul 29, 2021

Unwound really appreciate if you finish this PR and apply the comments. Thanks

I'll finish the PR this weekend

@fabpot
Copy link
Member

fabpot commented Aug 26, 2021

Thank you @damlox.

@fabpot fabpot merged commit 1e91b1a into symfony:5.3 Aug 26, 2021
@fabpot fabpot mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse left review comments

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Bug Notifier Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@damlox @carsonbot @OskarStark @fabpot @jderusse