Remove ReturnTypeWillChange
#42378
Merged
Remove ReturnTypeWillChange
#42378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably wait until #42379 has been merged up as well. |
|
#42379 has been merged. Please include the relevant changes here as well. |
derrabus
force-pushed
the
remove/return-type-will-change
branch
from
b5ea60c
to
8b2363b
Compare
|
Done. |
Tobion
reviewed
Aug 5, 2021
| @@ -601,12 +601,11 @@ public function in(string|array $dirs) | |||
| * | |||
| * This method implements the IteratorAggregate interface. | |||
| * | |||
| * @return \Iterator|SplFileInfo[] An iterator | |||
There was a problem hiding this comment.
we might want to fix those phpdocs in lower branches?
Tobion
reviewed
Aug 5, 2021
Tobion
approved these changes
Aug 5, 2021
derrabus
force-pushed
the
remove/return-type-will-change
branch
from
8b2363b
to
a419f80
Compare
|
The failing test is fixed and backported as #42384. I'll take care of the Psalm failures later. |
Tobion
added a commit
that referenced
this pull request
Aug 5, 2021
This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Fix broken mock | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Backport from #42378. This PR fixes a couple of mocked methods that currently return `null` although a real implementation would never do that. Commits ------- af37c64 Fix broken mock
azjezz
reviewed
Aug 5, 2021
derrabus
force-pushed
the
remove/return-type-will-change
branch
2 times, most recently
from
e76842e
to
ef2ab70
Compare
|
PR is ready again. |
derrabus
commented
Aug 10, 2021
src/Symfony/Component/Finder/Iterator/RecursiveDirectoryIterator.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
force-pushed
the
remove/return-type-will-change
branch
from
ef2ab70
to
2d3e1ed
Compare
Tobion
reviewed
Aug 10, 2021
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed the
ReturnTypeWillChangeattribute everywhere by adding actual return types.