Ignoring X-Transport header while signing email with DKIM #42659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metaer
changed the title
fabpot
requested changes
Aug 20, 2021
carsonbot
changed the title
metaer
force-pushed
the
5.3-ignore-x-transport
branch
from
e9dc858
to
b684d40
Compare
fabpot
approved these changes
Aug 20, 2021
|
Thank you @metaer. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier @fabpot wrote in symfony/symfony-docs#15603 (comment):
Original problem
If we have multiple transports and use one of them, signature will contain X-Transport header by default. But email will not:
symfony/src/Symfony/Component/Mailer/Transport/Transports.php
Line 56 in 810599d
And signature will be invalid.